AP_Mount/GCS_MAVLink: move handling of all do-set-roi to AP_Mount library #24654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbarker
requested changes
Aug 16, 2023
rmackay9
reviewed
Aug 17, 2023
rmackay9
reviewed
Aug 17, 2023
|
PeterB says, move this block from GCS_MAVLink::handle_command_long() to GCS_MAVLink::handle_command_int().. case MAV_CMD_DO_MOUNT_CONFIGURE: |
peterbarker
requested changes
Aug 17, 2023
khanasif786
force-pushed
the
do_set_roi_mount
branch
2 times, most recently
from
6353efb
to
04377de
Compare
khanasif786
force-pushed
the
do_set_roi_mount
branch
from
04377de
to
4e44ee1
Compare
|
@khanasif786, thanks for this. Can you clarify what testing has been done? .. and maybe update the Description above.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to issue #24571
Initial Draft
(Not tested yet so Draft)